Skip to content

refactor(@angular-devkit/build-angular): move dev-server webpack config in a separate file#19088

Merged
alan-agius4 merged 3 commits intoangular:masterfrom
alan-agius4:dev-server-config
Oct 16, 2020
Merged

refactor(@angular-devkit/build-angular): move dev-server webpack config in a separate file#19088
alan-agius4 merged 3 commits intoangular:masterfrom
alan-agius4:dev-server-config

Conversation

@alan-agius4
Copy link
Copy Markdown
Collaborator

No description provided.

@google-cla google-cla bot added the cla: yes label Oct 15, 2020
@alan-agius4 alan-agius4 marked this pull request as draft October 15, 2020 14:20
@alan-agius4 alan-agius4 marked this pull request as ready for review October 16, 2020 16:34
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Oct 16, 2020
@alan-agius4 alan-agius4 requested a review from clydin October 16, 2020 16:50
Comment thread packages/angular_devkit/build_angular/src/dev-server/index.ts Outdated
Comment thread packages/angular_devkit/build_angular/src/dev-server/ssl_spec.ts
…ig in a separate file

With this change we remove webpack dev-server logic to a seperate file. We also use the webpack-dev-server API to add live-reload and hmr entry-points and settings.
…en using protoactor

LIve-reload is not needed when using protoactor because watch mode is always disabled.
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Oct 16, 2020
@alan-agius4 alan-agius4 merged commit 574d309 into angular:master Oct 16, 2020
@alan-agius4 alan-agius4 deleted the dev-server-config branch October 16, 2020 19:08
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants